• src/sbbs3/logon.cpp

    From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Nov 30 21:02:49 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/69e23e724e4e9dd2cd905b7d
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Move the backup of dsts.ini before opening the file

    Can't backup (make copies of) an open file.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3b602ca5349f2b4143ff27ab
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Check return value of getnodedat()

    Should fix CID 515599 since this seems to be the only place we call unlocknodedat() without possibly not owning the nodefile_mutex already.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Feb 2 23:46:57 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b6b3e89091f941ab6ba3ea01
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Actually use the (first) shell we found that the user meets the requirements

    As discovered and reported by Deuce and Nelgin

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Feb 16 22:06:53 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/437b1a13e91a9878480671d7
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't backup dsts.ini daily

    Looks like an unintentional debug-inclusion with commit 2064f3a4f71c6656693a1 as pointed about by Deuce in IRC.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu May 1 11:57:17 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/9eaeedc13950d1ec26af5963
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Do rollover daily stats (dsts.ini) if the previous date was Jan-1-1970 (never)

    Basically revert commit 2064f3a4f71c6656693a1d24fc63004c3c41aaea

    In a new install, the "Date" value in dsts.ini will be 0/Never and thus would never be rolled over (e.g. stats moved o csts.tab files).

    Since getstats() now reliably detects any read failures, we shouldn't need
    this as a work-around any more anyway - if the "date" field is 0, it just
    means a new install and it's expected.

    This should fix the issue reported by Basis where the ctrl/csts.tab and node*/csts.tab files were never created in fresh install of v3.20. A work around is to just set the Date field in the ctrl/dsts.ini file to the current date (one time).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net